Skip to content

Conversation

@JslYoon
Copy link
Contributor

@JslYoon JslYoon commented Aug 4, 2025

Description of Changes

Updating go version from 1.21 to 1.24
Needed some linting changes (error output format) to keep up with 1.24 rules.

Related Issue(s)

devfile/api#1699

Acceptance Criteria

Testing and documentation do not need to be complete in order for this PR to be approved. However, tracking issues must be opened for missing testing/documentation.

New testing and documentation issues can be opened under devfile/api/issues.

You can check the respective criteria below if either of the following is true:

  • There is a separate tracking issue opened and that issue is linked in this PR.
  • Testing/documentation updates are contained within this PR.

If criteria is left unchecked please provide an explanation why.

  • [o] Unit/Functional tests

  • [o] QE Integration test

  • [o] Documentation (READMEs, Product Docs, Blogs, Education Modules, etc.)

@openshift-ci openshift-ci bot requested review from Jdubrick and elsony August 4, 2025 20:06
@JslYoon JslYoon requested review from elsony, maysunfaisal and michael-valdron and removed request for Jdubrick and elsony August 4, 2025 20:06
@JslYoon JslYoon moved this to In Review 👀 in Devfile Project Aug 4, 2025
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

I think after merging this one is good to create a new release for the library

@openshift-ci
Copy link

openshift-ci bot commented Aug 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JslYoon, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Aug 5, 2025
@JslYoon
Copy link
Contributor Author

JslYoon commented Aug 5, 2025

Also addressed devfile/api#1707

@JslYoon JslYoon merged commit 6a13a73 into main Aug 5, 2025
7 checks passed
@JslYoon JslYoon deleted the feature/go1.24 branch August 5, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In Review 👀

Development

Successfully merging this pull request may close these issues.

3 participants