Skip to content

Conversation

@logonoff
Copy link
Contributor

@logonoff logonoff commented May 2, 2025

Description of Changes

Summarize the changes you made as part of this pull request.

  • update distribution/reference to v0.6.0
  • update "github.com/distribution/distribution/v3/reference" imports to "github.com/distribution/reference"

Related Issue(s)

Link the GitHub/GitLab/JIRA issues that are related to this PR.

openshift/console#14841

Acceptance Criteria

no code changes. I am just updating an import as distribution/v3/reference does not appear to be a valid go import. this is causing some error in openshift console:

go: finding module for package github.com/distribution/distribution/v3/reference
go: github.com/openshift/console/pkg/devfile imports
	github.com/devfile/library/v2/pkg/devfile imports
	github.com/distribution/distribution/v3/reference: module github.com/distribution/distribution/v3@latest found (v3.0.0), but does not contain package github.com/distribution/distribution/v3/reference

@openshift-ci openshift-ci bot requested review from Jdubrick and michael-valdron May 2, 2025 19:02
Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@logonoff If you run make fmt_license and commit/push changes this should address the current build error.

@michael-valdron
Copy link
Member

@logonoff Oh I see it wasn't expecting the vendor source, yeah that should work 👍

@logonoff
Copy link
Contributor Author

logonoff commented May 2, 2025

@logonoff Oh I see it wasn't expecting the vendor source, yeah that should work 👍

yeah I was wondering why a one line change added 1.4 million lines of code 😅

@michael-valdron
Copy link
Member

Error: Missing download info for actions/upload-artifact@3cea5372237819ed00197afe530f5a7ea3e805c8

@devfile/devfile-services-team Looks like we're hitting the devfile/api#1707 issue under devfile/library as well, I'll expand that issue to include devfile/library as well.

@logonoff I'll ignore this check for this PR as its unrelated and not required to merge.

Copy link
Member

@michael-valdron michael-valdron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented May 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, michael-valdron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@michael-valdron
Copy link
Member

@logonoff Do you need help merging?

@michael-valdron michael-valdron merged commit d0fa9c1 into devfile:main May 2, 2025
5 of 6 checks passed
@logonoff logonoff deleted the dist branch May 2, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants