added dotnet80 stack support #93
Conversation
Signed-off-by: msivasubramaniaan <[email protected]>
There was a problem hiding this comment.
Nice addition. Looking at our current format I think the dotnet 8 was already supported, meaning that the framework could be detected.
It's nice that the current PR adds some tests around it. One thing I think would be usefull is to reduce the size of the dotnet8.0 test project. AFAIR we only need a few files in order to be able to detect the framework. As a result dirs like migration might be better if they are excluded from this project.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: msivasubramaniaan The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
msivasubramaniaan
force-pushed
the
add-dotnet8-support
branch
from
0bc3f9a
to
b795458
Compare
Signed-off-by: msivasubramaniaan <[email protected]>
| @@ -1,7 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk.Web"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>net6.0</TargetFramework> | |||
| <TargetFramework>net8.0</TargetFramework> | |||
There was a problem hiding this comment.
I think it makes sense to keep this as is (e.g net6.0) as there is already a new test case for net8.0 added above.
| @@ -35,7 +35,7 @@ func TestAnalyzeOnDjango(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestAnalyzeOnCSharp(t *testing.T) { | |||
| isLanguageInProject(t, "s2i-dotnetcore-ex", "c#", []string{}, []string{"net6.0"}) | |||
| isLanguageInProject(t, "s2i-dotnetcore-ex", "c#", []string{}, []string{"net8.0"}) | |||
There was a problem hiding this comment.
Same goes for this one. Might be better to add an additional test case instead of replacing the net6.0
What does this PR do?
Added stack
dotnet80supportWhich issue(s) does this PR fix
devfile/api#1540
devfile/registry#451
PR acceptance criteria
Testing and documentation do not need to be complete in order for this PR to be approved. We just need to ensure tracking issues are opened.
Unit/Functional tests
Documentation
How to test changes / Special notes to the reviewer