fixes : #1177 support variable values on open libery alizer's port de… #111
Conversation
…tection Signed-off-by: Horiodino <[email protected]>
| } | ||
| defer os.RemoveAll(tempDir) | ||
|
|
||
| hardcodedXML := ` |
There was a problem hiding this comment.
It might be better here for consistency reasons to keep the already existing flow by adding a test in https://github.com/devfile/alizer/blob/main/test/apis/component_recognizer_test.go#L159-L161 instead of creating the openliberty_detector_test.go
|
|
||
| ctx := context.TODO() | ||
|
|
||
| t.Run("Hardcoded Ports", func(t *testing.T) { |
There was a problem hiding this comment.
Is it possible to add a test case for a mix of hardcoded and variable based ports?
There was a problem hiding this comment.
Possibly one for empty var as well?
There was a problem hiding this comment.
+1 on the suggested test cases, as mentioned in #111 (comment) I'd prefer following the https://github.com/devfile/alizer/blob/main/test/apis/component_recognizer_test.go#L159-L161 example as the format of the tests.
|
/ok-to-test |
Signed-off-by: Horiodino <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Horiodino The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of Changes
resolves the port value by checking if it is a variable and if it is, it returns the value of the variable
Related Issue(s)
devfile/api#1177
Acceptance Criteria
Testing and documentation do not need to be complete in order for this PR to be approved. However, tracking issues must be opened for missing testing/documentation.
Unit/Functional tests
Documentation
Tests Performed
✔️️ Added suitable test case based on Issue.
How To Test
Instructions for the reviewer on how to test your changes.
Notes To Reviewer
Any notes you would like to include for the reviewer.