refactor: simplify image format dtype validation #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks @pratapvardhan could you please add a note in https://github.com/developmentseed/titiler/blob/main/CHANGES.md#unreleased |
pratapvardhan
force-pushed
the
core-ref
branch
2 times, most recently
from
2d3509d to
60c88a5
Compare
|
@vincentsarago resolved merge conflict with changes.md, this should be good for review now. |
pratapvardhan
force-pushed
the
core-ref
branch
from
60c88a5 to
1887633
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates dtype validation logic by using a lookup. Keeps the existing functionality intact, probably reduces repetitive code and makes it maintainable?
note: src/titiler/core tests are passing.
cc @vincentsarago – that said, if you feel this change isn’t really necessary, feel free to reject the PR. :)