Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use xarray.open_zarr and make aiohttp and s3fs optional #1016

Open
wants to merge 1 commit into
base: feature/add-xarray-package
Choose a base branch
from

Conversation

vincentsarago
Copy link
Member

This PR does:

  • remove reference and consolidated options
  • fall back to open_zarr when not dealing with netcdf files
  • make aiohttp and s3fs optional dependencies

Note:

  • we could also make h5netcdf and zarr optional but for this first version I think it's better to at least have something that support both format
  • in Theory, a user could provider its own opener method (Callable[..., xarray.Dataset]) making all the custom xarray dataset opener optional

@abarciauskas-bgse
Copy link
Contributor

This could still work with kerchunk references, do you know? If not I will try to test it. It may not matter if we go completely with icechunk stores (which should have the same access API as vanilla zarr stores) but it would be good to know if we were losing support for kerchunk references.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants