oryx unpin dotnet version and install using apt #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samruddhikhandale
requested changes
Jun 3, 2024
| echo "'dotnet 8' was not detected. Attempting to install .NET 8 to build oryx." | ||
|
|
||
| # The oryx build fails with .Net 8.0.201, see https://github.com/devcontainers/images/issues/974 | ||
| # Pinning it to a working version until the upstream Oryx repo updates the dependency | ||
| # install_dotnet_using_apt | ||
| PINNED_SDK_VERSION="8.0.101" |
There was a problem hiding this comment.
Looking at https://github.com/devcontainers/features/actions/runs/9348034682/job/25726319177?pr=991#step:4:914 doesn't seem like we can get rid of this just yet.
Let's move this to a draft PR and open back once the tests are 🟢
There was a problem hiding this comment.
converted this PR to Draft mode. will revisit when the dependent packages are up-to-date for this migration.
prathameshzarkar9
force-pushed
the
oryx_dotnet_unpin_version
branch
from
5c50ae4
to
3bc9e31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 885
Feature Name:
Description:
This PR does the following -
Changelog:
Checklist: