Add Arch support for common-utils #791
Conversation
|
@microsoft-github-policy-service agree company="openscript GmbH" |
|
Thank you for the contribution. We will review it soon. |
|
We have some failing tests |
|
Looks like the tests are failing on alpine libssl stuff which was worked on here: Perhaps the tests just need to be re-run on a checkout with devcontainers:main's latest changes? |
|
I've updated from upstream. Let's see if the issue is resolved. |
| @@ -311,6 +311,53 @@ install_alpine_packages() { | |||
| PACKAGES_ALREADY_INSTALLED="true" | |||
There was a problem hiding this comment.
Can we bump the minor version for this Feature?
| @@ -311,6 +311,53 @@ install_alpine_packages() { | |||
| PACKAGES_ALREADY_INSTALLED="true" | |||
| } | |||
|
|
|||
| # Arch Linux packages | |||
| install_arch_packages() { | |||
There was a problem hiding this comment.
Can we add test scenarios to validate these PR changes? Thanks!
| @@ -311,6 +311,53 @@ install_alpine_packages() { | |||
| PACKAGES_ALREADY_INSTALLED="true" | |||
| } | |||
|
|
|||
| # Arch Linux packages | |||
There was a problem hiding this comment.
Can we updates NOTES.md's OS support section to include Arch Linux?
This pull requests adds ArchLinux support for the common-utils feature. This comes in handy if you want to set up a ArchLinux devcontainer.
Based on this work it will become possible to add a ArchLinux base image.