Add RHEL support to git feature #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…os7, alma-{8,9}, alma-{8,9}-minimal
Fixes #1 Git feature passes all tests: existing + rhel-based base images: cent…
eljog
reviewed
Dec 12, 2023
There was a problem hiding this comment.
Thank you for the PR. We really appreciate the time you have taken to contribute to the community.
- I have added a few comments
- Please accept the CLA
|
CLA has been submitted for review by our Legal team. I'm working to get it approved and signed as soon as possible. |
eljog
reviewed
Dec 13, 2023
|
@microsoft-github-policy-service agree company="Analog Devices" |
samruddhikhandale
requested changes
Jan 26, 2024
samruddhikhandale
requested changes
Jan 26, 2024
Co-authored-by: Samruddhi Khandale <[email protected]>
samruddhikhandale
requested changes
Jan 26, 2024
|
Samrhuddhi: Thank you for all the feedback and input. I think I've addressed all your inputs and requested changes and improvements. Please let me know if there is more I need to do. Thanks, Jeff. |
samruddhikhandale
approved these changes
Jan 29, 2024
|
Samrhuddhi: Thank you again for the thoughtful and helpful sugguestions. Jeff. |
|
@jdputschadi Let me know if you'd like to be added to the community slack channel. Instructions in https://github.com/orgs/devcontainers/discussions/3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds RHEL support to git feature.
CentOS 7, RHEL/Alma/Rocky Linux 8 & 9 should all work. Testing was done with centos7, almalinux 8 and almalinux 9.
Includes ability to build feature on alma minimal base images.
resolves #781