Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] Support groovy installations #779

Merged
merged 5 commits into from
Jan 22, 2024
Merged

[java] Support groovy installations #779

merged 5 commits into from
Jan 22, 2024

Conversation

Ash258
Copy link
Contributor

@Ash258 Ash258 commented Dec 9, 2023

Tests are failing for some reason with version 19. I used 21 instead to make tests work again

image

@Ash258
[java] Support groovy installations
2a53c70 
Fix java test failing with non existent 19 version of `open` distro
@Ash258
fix: Typo
f720589
@Ash258 Ash258 requested a review from a team as a code owner December 9, 2023 11:38
@Ash258
Copy link
Contributor Author

Ash258 commented Dec 9, 2023

@microsoft-github-policy-service agree

samruddhikhandale
samruddhikhandale requested changes Jan 17, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for adding the super helpful Feature option.

Left minor comments, besides that looks great!

src/java/devcontainer-feature.json Outdated Show resolved Hide resolved
src/java/devcontainer-feature.json Outdated Show resolved Hide resolved
test/java/scenarios.json Show resolved Hide resolved
samruddhikhandale
samruddhikhandale approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! 🚀

@samruddhikhandale samruddhikhandale merged commit 76ffd41 into devcontainers:main Jan 22, 2024
11 checks passed
@Ash258 Ash258 deleted the java/groovy_test_fixes branch January 23, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ash258 @samruddhikhandale