Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[node] Install the latest version of nvm by default #673

Merged
merged 2 commits into from
Aug 28, 2023
Merged

[node] Install the latest version of nvm by default #673

merged 2 commits into from
Aug 28, 2023

Conversation

eitsupi
Copy link
Contributor

@eitsupi eitsupi commented Aug 25, 2023

Close #666

@eitsupi eitsupi requested a review from a team as a code owner August 25, 2023 14:08
@eitsupi eitsupi changed the title feat(node): install the latest nvm by default [node] Install the latest version of nvm by default Aug 25, 2023
@eitsupi
Copy link
Contributor Author

eitsupi commented Aug 26, 2023

The test failure does not seem to do with this change (#675).

samruddhikhandale
samruddhikhandale approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! ✨

@samruddhikhandale samruddhikhandale merged commit 95a169b into devcontainers:main Aug 28, 2023
11 of 12 checks passed
@eitsupi eitsupi deleted the nvm-version branch August 28, 2023 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why not the node Feature installs the latest nvm by default?
2 participants
@eitsupi @samruddhikhandale