[common-utils]: Bug fix: Install zsh on an image previously built with "installZsh:false" #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… samruddhikhandale/common-utils-zsh-bug
|
Please also see #653 |
… samruddhikhandale/common-utils-zsh-bug
joshspicer
approved these changes
Sep 13, 2023
@joshspicer Yes, that's correct! |
samruddhikhandale
deleted the
samruddhikhandale/common-utils-zsh-bug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #647
Testes locally with an image provided in #647 (comment). Works as expected!
Unfortunately, I wasn't able to write a test for such a complex scenario, feedbacks on how to write a test are welcome 🙏