Remove deprecated Python settings #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 21, 2023
|
Took the liberty to remove the linters and formatters from DEFAULT_UTILS, but happy to revert if it not appropriate! 😊 |
|
@samruddhikhandale friendly ping 😊 |
samruddhikhandale
requested changes
Aug 7, 2023
This reverts commit 57c7bec.
|
Last commit reverted 😊 |
|
@samruddhikhandale friendly ping! |
|
@luabud I had been waiting for this comment https://github.com/devcontainers/features/pull/625/files#r1286251867 Can you help resolve it, then we could merge this PR. Thanks! |
|
@samruddhikhandale oh I'm so sorry! I had totally misunderstood that this would be done in a follow up clean up PR (which I now realize was about bumping the major version, instead of minor 🤦♀️) Just bumped the version to it to 1.2.1 :) thanks a lot! |
samruddhikhandale
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
The
python.lintingandpython.formattingsettings have been deprecated as in the latest Python extension pre-release version, as we're migrating our tooling support to extensions (see here for more details).We figured we'd submit PRs to remove them from devcontainers configs 😊