Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a feature that installs dependencies from an Aptfile.dev file #1136

Conversation

viktorianer
Copy link

Description:

This PR introduces a new feature for installing apt dependencies in the DevContainer environment using an Aptfile.dev file. The feature simplifies the process of managing apt packages required for the development environment by specifying them in a file and automating the installation during the container setup process.

Usage:

To use the feature, include the following in your devcontainer.json:

{
  "features": {
    "ghcr.io/devcontainers/features/apt:1": {
      "devFile": "../Aptfile.dev"
    }
  }
}

Example Aptfile.dev

# Video thumbnails
ffmpeg
libvips

# PDF thumbnails
poppler-utils

# PostgreSQL
libpq-dev
postgresql-client

Additional Information:

Based on the approach found in https://github.com/heroku/heroku-buildpack-apt and https://docs.digitalocean.com/products/app-platform/reference/buildpacks/aptfile/.

@viktorianer viktorianer requested a review from a team as a code owner October 2, 2024 17:33
@viktorianer
Copy link
Author

@microsoft-github-policy-service agree

@eitsupi
Copy link
Contributor

eitsupi commented Oct 4, 2024

@viktorianer Have you read the README and CONTRIBUTING.md?

This repository will accept improvement and bug fix contributions related to the current set of maintained Features.

features/CONTRIBUTING.md

Lines 20 to 28 in 302feca

## Contributing code
👨‍💼 This repository is a collection of dev container Features managed by dev
container spec maintainers. This repository will **only accept improvements and
bug fixes** for the [current set of maintained Features].
🚀 If you're looking to create a new Feature, then we encourage adding it to a
separate repository of your control. The [devcontainers/feature-starter]
repository has more guidance on self authoring Features.

I don't think contributions to add new Features are acceptable.

@viktorianer
Copy link
Author

viktorianer commented Oct 4, 2024

Thank you for the feedback. I have reviewed those documents and understand that this repository focuses on improvements and bug fixes for the existing set of maintained Features.

I completely understand if adding a new Feature doesn’t align with the current goals of this repository.

If this contribution is not considered for merging, I’m happy to proceed by maintaining this Feature in a separate repository.

Thank you for your time and consideration!

@samruddhikhandale
Copy link
Member

Hi 👋

As @eitsupi already mentioned, we appreciate your Feature contribution, however, the devcontainers/features repo only accepts improvements and bug fixes for the current set of maintained Features.

However, we would appreciate if you could add this Feature in a separate repository of your control. The devcontainers/feature-starter repo has more guidance on self authoring them.

Once you've self authored and if you'd like to share it with the community, we'd recommend adding it to the index. It will make them visible in our supporting tools (like https://containers.dev/templates, Dev Containers Extension, GitHub Codespaces etc).

Feel free to ask any questions/queries along the way, feedbacks are welcome too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants