Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Nvm Source Issue(#1078) #1114

Merged
merged 5 commits into from
Oct 22, 2024
Merged

Fixed Nvm Source Issue(#1078) #1114

merged 5 commits into from
Oct 22, 2024

Conversation

gvatsal60
Copy link
Contributor

  • Fixed nvm source issue

See the issue at #1078

@gvatsal60 gvatsal60 requested a review from a team as a code owner September 5, 2024 05:42
@gvatsal60 gvatsal60 mentioned this pull request Sep 5, 2024
Closed
@samruddhikhandale samruddhikhandale linked an issue Sep 25, 2024 that may be closed by this pull request
failed to build with error: bash: "/usr/local/share/nvm/nvm.sh: No such file or directory" #1078
Closed
samruddhikhandale
samruddhikhandale requested changes Sep 25, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay, this PR slipped through the cracks.

src/node/install.sh Show resolved Hide resolved
samruddhikhandale
samruddhikhandale requested changes Oct 8, 2024
View reviewed changes
src/node/install.sh Outdated Show resolved Hide resolved
samruddhikhandale
samruddhikhandale approved these changes Oct 22, 2024
View reviewed changes
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, let's merge once the tests are green! ⚡

@samruddhikhandale samruddhikhandale merged commit 2951f04 into devcontainers:main Oct 22, 2024
12 checks passed
@gvatsal60 gvatsal60 deleted the fix/node_issues branch October 23, 2024 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samruddhikhandale samruddhikhandale samruddhikhandale approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

failed to build with error: bash: "/usr/local/share/nvm/nvm.sh: No such file or directory"
2 participants
@gvatsal60 @samruddhikhandale