Features update logic for PPA in bionic #1079

prathameshzarkar9 · 2024-08-06T20:05:09Z

Issue 1062
Features: Update logic for PPA in bionic

Feature Name

common-utils
go
java
node
python

Changelog

Changes to install.sh and devcontainer-feature.json for features update

Checklist

code snippet is added at specific position in all the install.sh of mentioned features
Bumped all the version for the mentioned features

src/java/install.sh

src/node/install.sh

src/common-utils/main.sh

src/java/devcontainer-feature.json

src/node/devcontainer-feature.json

src/node/install.sh

test/node/scenarios.json

src/node/devcontainer-feature.json

samruddhikhandale

Looks good!

prathameshzarkar9 requested a review from a team as a code owner August 6, 2024 20:05

prathameshzarkar9 mentioned this pull request Aug 6, 2024

Features: Update logic for PPA in bionic #1062

Closed

samruddhikhandale requested changes Aug 7, 2024

View reviewed changes

src/java/install.sh Outdated Show resolved Hide resolved

src/node/install.sh Outdated Show resolved Hide resolved

prathameshzarkar9 force-pushed the update-logic-for-ppa branch from bc563db to 58a5dad Compare August 8, 2024 15:55

samruddhikhandale requested changes Aug 9, 2024

View reviewed changes

src/node/install.sh Show resolved Hide resolved

src/node/install.sh Outdated Show resolved Hide resolved

samruddhikhandale reviewed Aug 13, 2024

View reviewed changes

src/node/install.sh Outdated Show resolved Hide resolved

samruddhikhandale requested changes Aug 13, 2024

View reviewed changes

src/node/install.sh Outdated Show resolved Hide resolved

prathameshzarkar9 force-pushed the update-logic-for-ppa branch from e686913 to 498f348 Compare August 16, 2024 09:55

prathameshzarkar9 added 12 commits August 20, 2024 08:30

Features update logic for PPA in bionic

8ab00f7

node failing fixed after pnpm install from npm package manager

7a7a54b

for node version 16 pnpm version 7 is installed

fcc3844

uninstalled pnpm package first and then reinstalled as per node version

a55d07c

force installing pnpm package

d79b1f5

optimized logic to install compatible pnpm for node 16

7dc1ae9

pnpm install specific version compatible for node

f7b1e10

new variable added pnpmVersion in node feature

9b98aee

test case failure fixed

9ee2be7

fixed test cases

508e106

fixing test cases

25d2611

pnpm version fixed for test cases

4dde19a

prathameshzarkar9 force-pushed the update-logic-for-ppa branch from a5cf31e to 4dde19a Compare August 20, 2024 08:31

default version for pnpm updated

5d805e7

samruddhikhandale requested changes Aug 20, 2024

View reviewed changes

review comments addressed

f516ed3

samruddhikhandale linked an issue Aug 27, 2024 that may be closed by this pull request

Features: Update logic for PPA in bionic #1062

Closed

samruddhikhandale reviewed Aug 27, 2024

View reviewed changes

src/node/devcontainer-feature.json Outdated Show resolved Hide resolved

Update src/node/devcontainer-feature.json

e866fe0

samruddhikhandale approved these changes Aug 27, 2024

View reviewed changes

samruddhikhandale merged commit 52c79b4 into devcontainers:main Aug 27, 2024
12 of 14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Features update logic for PPA in bionic #1079

Features update logic for PPA in bionic #1079

prathameshzarkar9 commented Aug 6, 2024

samruddhikhandale left a comment

Features update logic for PPA in bionic #1079

Features update logic for PPA in bionic #1079

Conversation

prathameshzarkar9 commented Aug 6, 2024

samruddhikhandale left a comment

Choose a reason for hiding this comment