Skip to content

Test sonarcloud #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Test sonarcloud #1

wants to merge 2 commits into from

Conversation

gmuecke
Copy link
Member

@gmuecke gmuecke commented Jul 3, 2018

No description provided.

gmuecke
gmuecke commented Jul 3, 2018
View reviewed changes
Copy link
Member Author

@gmuecke gmuecke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SonarQube analysis found issues:
Bug Bugs: 0
Vulnerability Vulnerabilities: 0
Code Smell Code Smells: 1

See all issues in SonarCloud

src/main/java/io/devcon5/vertx/services/AbstractService.java
@@ -124,6 +124,7 @@ public T withConfig(final JsonObject config) {
*/
protected void start(final Future<Void> startFuture) {

System.out.println("you shall not use system.out.println");
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Smell Code Smell: Replace this use of System.out or System.err by a logger. (squid:S106)

See it in SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gmuecke