added question pages

[armydar]

No description provided.

[abiodun0]

@armydar Can you update this PR with screen shots?

[armydar]

good evening... please i don't understand the question.

…

On Tue, Jul 18, 2017 at 8:43 PM, Abiodun Shuaib ***@***.***> wrote: Closed #10 <#10>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#10 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AVkb4Dd3Py9VyxCWRWBHpm7Ru92XFx_eks5sPQrGgaJpZM4OaUmx> .

[armydar]

BEGIN

QUESTION 1

QUESTION 2

QUESTION 3

[armydar]

HOW TO JOIN

[abiodun0]

The logo as it appears seems too big. This should be made to be a regular navigation local like in popular websites. You can use devcenter.co as a guide when doing this.

Overall Good job. But this seem to be designed without atheistic and making it visually appealing in mind. Please put this into consideration when implementing the feedbacks. add a css file or use a css framework will be a +

[abiodun0]

Code Quality: Critical
This seems to be designed without any use of css or care for responsiveness. This should be refactored and appropriate css should be used.

[armydar]

yes...no styling as the #4 is basically to create plain html

[abiodun0]

Code Quality: Nitpick
This should be revisited and divided into reasonable divs

[osioke]

@abiodun0 this PR addresses just the HTML pages, in the next task she is to add the CSS files, and beautify it.

@armydah to help make this clearer on your next pull request (PR), you could do the following:

• The name of PR should show what the PR is about. In this case the PR is a solution/fix for a named issue, so you should name your PR to show that it is a fix for that issue. For example you could say Added plain HTML files for the pages to fix #4 or Plain HTML pages created to fix #4. Writing the no of the issue after a pound sign (#) helps mention that issue.

Also @armydar what @abiodun0 is saying is the way you wrote the HTML and how you structured the divs and other tags can be done better, and the images you added are not resized and thus they appear too big, and make the site look unappealing. You should fix the image, and check the tags you used and how you can reduce or use them better.

I also checked the files, and noticed a few things.

• The HTML file for the first page (the landing page) is not included here.
• The files should be arranged together in a folder, this will help create a folder structure, which helps organize and keep your files easily understandable by a browser.
• The image folder is not included in this pull request, making the image not load if accessed outside your laptop
• The buttons do not link to the other pages, that is not links from one page to the other. And so one cannot go through the pages as if using the app. You can read the flow of the app starting here to see how the app works, and how each page is supposed to link to each other.
• The questions are not meant to be entered on the page using HTML, they are to be pulled from the database using JavaScript, and you would address this in a later task. And so the question pages are meant to be template pages. See this explainer card to understand better. You can ask @abiodun0 how you can create the pages, or if you are supposed to create them now.

Good one generally, I will drop my finally feedback on the Slack channel.

[abiodun0]

@osioke Awesome .. those this means i can merge this request?

[osioke]

At all @abiodun0, she still has to do the landing page, group all the front-end work in a folder on the repo, link the pages, add the image folder, and redo the template page for the questions and resource. cc: @armydah

[armydar]

fixed issue #5 @abiodun0