Skip to content

feat: new notebook contents view layout with search & lazy loading with pagination #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aavshr merged 24 commits into from
Nov 19, 2025
Merged

feat: new notebook contents view layout with search & lazy loading with pagination #77

aavshr merged 24 commits into from
Nov 19, 2025

Conversation

@aavshr
Copy link
Collaborator

@aavshr aavshr commented Nov 10, 2025 •
edited
Loading

Changes

  • Update the notebook view (root & within a notebook) to categories instead of tabs to support quick Search
    • Add support for Search in the layout
  • Implement pagination in list resource ids APIs and use lazy loading on scroll for resource loading

@github-actions
Copy link

github-actions bot commented Nov 10, 2025

✅ Build completed successfully for version aavash-search-fix-24118a7

Download artifacts:

@aavshr aavshr requested a review from xeust November 10, 2025 16:56
@aavshr aavshr force-pushed the aavash/search-fix branch 3 times, most recently from dacfd5d to 33bb034 Compare November 14, 2025 14:46
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

✅ Build completed successfully for version aavash-search-fix-848c7ba

Download artifacts:

aavshr added 21 commits November 18, 2025 17:51
@aavshr
feat (backend): pagination in list resource ids by tags apis
7309fc1 
Signed-off-by: Aavash Shrestha <[email protected]>
@aavshr
chore: use list resources by tags paginated APIs in sffs and resource…
f093af1 
… manager services

Signed-off-by: Aavash Shrestha <[email protected]>
@aavshr
chore: use pagination load APIs in SurfLoader component
4fa894e 
Signed-off-by: Aavash Shrestha <[email protected]>
@aavshr
feat: search input in notebook contents view
40cdc01 
Signed-off-by: Aavash Shrestha <[email protected]>
@aavshr
feat: category views in notebook contents
cd14cdd 
Signed-off-by: Aavash Shrestha <[email protected]>
@aavshr
chore: refactor for loading and no results snippet and only show add …
7913906 
…button on non collapsed

Signed-off-by: Aavash Shrestha <[email protected]>
@aavshr
chore: responsive notebook main layout and content max heights
aaf4f0b 
Signed-off-by: Aavash Shrestha <[email protected]>
@aavshr
chore: also allow library to be collapsed
df47fc0 
Signed-off-by: Aavash Shrestha <[email protected]>
@aavshr
chore: move Drafts notebook init to notebooks list and have no result…
823529c 
…s snippet for notebooks as well

Signed-off-by: Aavash Shrestha <[email protected]>
@aavshr
chore: remove collapsable library state from notebook contents view
262fac1 
Signed-off-by: Aavash Shrestha <[email protected]>
@aavshr
chore: use scroll to load behavior with pagination in NotebookContent…
54b86f1 
…s view

Signed-off-by: Aavash Shrestha <[email protected]>
@aavshr
chore: deprecate include annotations param in search resources API
bf91eb7 
Signed-off-by: Aavash Shrestha <[email protected]>
@aavshr
chore: remove unneeded onMount hook on NotebookContents view
6822530 
Signed-off-by: Aavash Shrestha <[email protected]>
@aavshr
fix (backend): use updated_at along with id for pagination
6fa3eb7 
Signed-off-by: Aavash Shrestha <[email protected]>
@aavshr
fix (backend): fix pagination query for list resource ids by tags
522a687 
Signed-off-by: Aavash Shrestha <[email protected]>
@aavshr
chore: refactor and use single API and loader component for listing r…
83f873b 
…esources

Signed-off-by: Aavash Shrestha <[email protected]>
@aavshr
fix: fix context menu check for notebook cover & add prop for showing…
4c48919 
… heart sticker

Signed-off-by: Aavash Shrestha <[email protected]>
@aavshr
chore: remove animations in NotebookContents view
16cca46 
Signed-off-by: Aavash Shrestha <[email protected]>
@aavshr
fix: readd removed NotebookLoader file but use SurfLoader in notebook…
225bad5 
… sidebar

Signed-off-by: Aavash Shrestha <[email protected]>
@aavshr
chore (backend): also use space id filter in other resource id list a…
36fe1ea 
…pis and pass filter from search api

Signed-off-by: Aavash Shrestha <[email protected]>
@aavshr
fix: use loading snippet for search as well as do not filter on resou…
e0cae2c 
…rces and simply use search results in Surf Loader

Signed-off-by: Aavash Shrestha <[email protected]>
@aavshr aavshr changed the title feat: new notebook contents view layout with search feat: new notebook contents view layout with search & lazy loading with pagination Nov 18, 2025
@aavshr aavshr marked this pull request as ready for review November 18, 2025 16:54
@github-actions
Copy link

github-actions bot commented Nov 18, 2025

✅ Build completed successfully for version aavash-search-fix-c67ea27

Download artifacts:

@aavshr aavshr merged commit 4650178 into main Nov 19, 2025
3 checks passed
@aavshr aavshr deleted the aavash/search-fix branch November 19, 2025 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xeust xeust xeust approved these changes

Assignees

No one assigned

Labels

pr-build-mac

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aavshr @xeust