Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(collections): support iterators in sortBy() #5919

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

babiabeo
Copy link
Contributor

@babiabeo babiabeo commented Sep 5, 2024

Towards: #5470

@babiabeo babiabeo requested a review from kt3k as a code owner September 5, 2024 12:24
@babiabeo babiabeo changed the title feat(collections/sortBy): support iterators feat(collections): support iterators in sortBy() Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (766d9c4) to head (41c519a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5919      +/-   ##
==========================================
- Coverage   96.25%   96.24%   -0.02%     
==========================================
  Files         491      491              
  Lines       39460    39451       -9     
  Branches     5824     5822       -2     
==========================================
- Hits        37983    37970      -13     
- Misses       1433     1437       +4     
  Partials       44       44              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iuioiua
Copy link
Collaborator

iuioiua commented Sep 9, 2024

Sorry for the delay. We're deciding how to best handle these changes that should probably be considered unstable.

@babiabeo
Copy link
Contributor Author

babiabeo commented Sep 9, 2024

I see. No problem 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants