fix: kill zombie builds if they complete #2318
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on a dependency visualizer in order to learn more about
deno_graph
and various network diagram visualization libraries. I've started out withvis-network
, but I quickly encountered a problem when deploying: despite thebuild()
function inbuild.ts
finishing, the process doesn't end!This is different than #2240 because... I dunno, I just think it is. I've gated the code in the fixture with the standard advice:
!Deno.args.includes("build")
, but this does not help. But if you comment outDeno.exit()
then it starts hanging again. And going a step further, commenting out the code in the effect like this:causes the build to finish, even though that code isn't even running on the server.
Perhaps I'm going about this wrong and I should instead be importing
vis-network
dynamically, if we're not in build mode? I'm really unsure what's going on here, but using the code in the forked branch unblocked my project, so I thought I would clean it up enough and write a test -- perhaps it's useful for someone else.