Conversation
|
deploy/_data.ts
Outdated
| title: "Crons", | ||
| href: "/deploy/reference/crons/", |
deploy/reference/cron_jobs.md
Outdated
| @@ -0,0 +1,138 @@ | |||
| --- | |||
| title: Crons | |||
There was a problem hiding this comment.
Is there a reason for us calling this feature Crons instead of Cron?
Cron feels more correct, with the descriptive plural form being "cron tasks" or "cron jobs" as we've used in the past and seems to be the wider norm
There was a problem hiding this comment.
I haven't really given it any thought. Now that you mention it though, my preference would be Cron Jobs.
There was a problem hiding this comment.
However, if we go with "Cron Jobs", we should update the UI accordingly. @donjo
There was a problem hiding this comment.
I think the feature should be Cron and that the UI should correspond. In prose and where we are talking about multiple registered cron items, "cron jobs" seems standard and appropriately descriptive
There was a problem hiding this comment.
That sounds right to me, we can update the UI accordingly to match what is being proposed here.
There was a problem hiding this comment.
Renamed feature to "Cron", and normalized all references in text to "cron job(s)". See e71d5bc
deploy/reference/cron_jobs.md
Outdated
|
|
||
| Cron executions progress through these statuses: | ||
|
|
||
| | Status | Color | Description | |
There was a problem hiding this comment.
This traffic light status description appears before any mention of a UI in the console. Should the existence of the cron dashboard be mentioned first so that this is more meaningful?
There was a problem hiding this comment.
I could just remove the color column? it does not add much value.
deploy/reference/cron_jobs.md
Outdated
| The **Crons** tab in the app sidebar gives you an overview of all registered | ||
| crons across your project. Each entry shows the cron's schedule, its most recent | ||
| executions, and the active [timelines](/deploy/reference/timelines/) it belongs | ||
| to. When a cron with the same name is registered with different schedules on |
There was a problem hiding this comment.
What happens if an attempt to use the same name is made on a single timeline?
There was a problem hiding this comment.
I'm not sure I understand what you mean
There was a problem hiding this comment.
There is a description here of what happens if the same name for a cron job is used in different timelines. I curious to know what happens if the sane name is used twice, perhaps in error, in a single timeline.
Deno.cron("cleanup-old-data", "0 * * * *", () => {
console.log("Cleaning up old data...");
});
//....
Deno.cron("cleanup-old-data", "6 * * * *", () => {
console.log("Cleaning up other old data...");
});
There was a problem hiding this comment.
Oh. That's a runtime error, and your revision will fail to warmup.
deploy/reference/crons.md
Outdated
| ## Limitations | ||
|
|
||
| - Crons must be registered at the module top level (before `Deno.serve()`) | ||
| - No concurrent executions of the same cron |
There was a problem hiding this comment.
- No concurrent executions of the same cron
What exactly does that mean? Could we be a tiny bit more descriptive here in the interest of driving out any ambiguity?
There was a problem hiding this comment.
Honestly, besides the billing point, the rest are already explained in length above. I'm considering removing the section alltogether, and adding a billing section explaining how billing works
philhawksworth
left a comment
There was a problem hiding this comment.
Looking good!
I've added some questions and comments.
A fundamental one is about the naming of this as Crons vs Cron, which might bring about the need for a few edits for consistency depending on what is decided.
https://docs--crons.deno.deno.net/deploy/reference/crons/