Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make lint rule docs better looking #1277

Merged
merged 15 commits into from
Dec 20, 2024
Merged

Conversation

crowlKats
Copy link
Member

No description provided.

@josh-collinsworth
Copy link
Contributor

josh-collinsworth commented Dec 17, 2024

Is there a reason we have jsx and react in here? I don't see any that currently use those rules. Guessing for future work?

In any case, we should probably flesh out the descriptions up top a little bit more. There's also plenty of room for other improvement, but I thought this was a serviceable start.

@bartlomieju
Copy link
Member

@josh-collinsworth yes, we got a bunch of incoming rules that have these tags that will be available once denoland/deno#27162 lands.

@bartlomieju bartlomieju marked this pull request as ready for review December 20, 2024 23:58
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, going to land it as is and further improve in follow up PRs.

@bartlomieju bartlomieju merged commit 83ef793 into main Dec 20, 2024
4 checks passed
@bartlomieju bartlomieju deleted the beautify-lint-docs branch December 20, 2024 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants