fix: use normalized version constraints #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dsherret
commented
Aug 27, 2024
•
dsherret
commented
- Uses feat: ability to get a normalized version constraint deno_semver#32
bartlomieju
reviewed
Aug 28, 2024
Comment on lines
+850
to
+861
| let err = Lockfile::new(NewLockfileOptions { | ||
| file_path, | ||
| content: "{ \"version\": \"2000\" }", | ||
| overwrite: false, | ||
| }) | ||
| .unwrap_err(); | ||
| match err.source { | ||
| LockfileErrorReason::UnsupportedVersion { version } => { | ||
| assert_eq!(version, "2000") | ||
| } | ||
| _ => unreachable!(), | ||
| } |
There was a problem hiding this comment.
Nice, see you in 4000 years 🖐️
bartlomieju
reviewed
Aug 28, 2024
Comment on lines
+32
to
+36
| // WARNING: It's important to implement Ord/PartialOrd on the final | ||
| // normalized string so that sorting works according to the final | ||
| // output and so that's why this is used rather than JsrDepPackageReq | ||
| // directly. | ||
| #[derive(Debug, PartialEq, Eq, PartialOrd, Ord, Serialize)] |
There was a problem hiding this comment.
Great, there's a warning, is there a test that asserts that as well?
There was a problem hiding this comment.
I'll try to come up with one.
There was a problem hiding this comment.
Can't think of one atm 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.