Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename types.d.ts to type.ts #319

Merged
merged 1 commit into from
Nov 5, 2023

Conversation

yacinehmito
Copy link
Contributor

Declaration files should only be used to represent types that result from the transpilation of TypeScript to JavaScript. In a TypeScript context, it can cause issues that, from my understanding, relate to ambient types.

@CLAassistant
Copy link

CLAassistant commented Nov 4, 2023

CLA assistant check
All committers have signed the CLA.

Declaration files should only be used to represent types that result
from the transpilation of TypeScript to JavaScript. In a TypeScript
context, it can cause issues that, from my understanding, relate to
ambient types.
Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dsherret dsherret merged commit 16d3341 into denoland:main Nov 5, 2023
3 checks passed
@yacinehmito yacinehmito deleted the no-declaration-file branch November 5, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants