feat(symbols): symbol members #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsherret
commented
Nov 5, 2023
| } | ||
|
|
||
| #[derive(Debug, Clone)] | ||
| pub struct SymbolMember { |
There was a problem hiding this comment.
SymbolMember could probably be generalized into Symbol, but it's a little bit challenging with the borrow checker in Rust. I will open a separate PR for that.
There was a problem hiding this comment.
This PR is actually superceeded by #322 , but this one needs to merge first because it's starting to get very complicated with all these branches I have.
bartlomieju
approved these changes
Nov 6, 2023
Comment on lines
+145
to
147
| #[derive(Clone, Copy)] | ||
| pub struct CapturingModuleParser<'a> { | ||
| parser: Option<&'a dyn ModuleParser>, |
There was a problem hiding this comment.
Are these fields internally ref-counted or are these copies/clones expensive?
There was a problem hiding this comment.
No. This is just clones of some references so very cheap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on #317This is actually going to be mostly rewritten in #322 , but it's easier to land this one first because I have a draft PR inbetween these two.