feat(type_tracing): store swc nodes with symbol #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
approved these changes
Oct 11, 2023
Comment on lines
+153
to
+155
| /// WARNING: Ensure that T is a reference inside ParsedSource. Otherwise | ||
| /// this is entirely unsafe. | ||
| fn unsafe_new(parsed_source: &ParsedSource, value: &T) -> Self { |
There was a problem hiding this comment.
Maybe this should be an unsafe fn and you can ensure T inside it?
There was a problem hiding this comment.
I would for sure if this was public, but since it's private to the module, it's less verbose to just rely on unsafe in the name.
What do you mean by "and you can ensure T inside it?"?
There was a problem hiding this comment.
What do you mean by "and you can ensure
Tinside it?"?
I meant this part Ensure that T is a reference inside ParsedSource. Otherwise this is entirely unsafe.. But if that's private I think it's fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to get the swc declaration from a symbol. This is useful for deno_doc because we can take a module symbol, then traverse the exports creating DocNodes.
I have good internet connection now, so I'm going to stop working on the deno_doc update after this PR and get back to other more important things.