fix(type_tracing): range for default decl should be the decl range (#301

)
denoland · Oct 9, 2023 · 5ccfa34 · 5ccfa34
1 parent 9b71ac2
commit 5ccfa34
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 21 deletions.
diff --git a/src/type_tracer/analyzer.rs b/src/type_tracer/analyzer.rs
@@ -1074,7 +1074,7 @@ impl<'a, THandler: TypeTraceHandler> SymbolFiller<'a, THandler> {
               id.clone(),
               SymbolDecl {
                 kind: SymbolDeclKind::Definition,
-                range: ident.range(),
+                range: default_decl.decl.range(),
               },
             );
             file_module

diff --git a/tests/specs/type_tracing/Basic.txt b/tests/specs/type_tracing/Basic.txt
@@ -404,10 +404,10 @@ file:///a.ts: EsmModuleSymbol {
                 SymbolDecl {
                     range: SourceRange {
                         start: SourcePos(
-                            165,
+                            159,
                         ),
                         end: SourcePos(
-                            166,
+                            170,
                         ),
                     },
                     kind: Definition,

diff --git a/tests/specs/type_tracing/ExportDefault01.txt b/tests/specs/type_tracing/ExportDefault01.txt
@@ -435,10 +435,10 @@ file:///a.ts: EsmModuleSymbol {
                 SymbolDecl {
                     range: SourceRange {
                         start: SourcePos(
-                            161,
+                            155,
                         ),
                         end: SourcePos(
-                            165,
+                            182,
                         ),
                     },
                     kind: Definition,
@@ -582,10 +582,10 @@ file:///interface.ts: EsmModuleSymbol {
                 SymbolDecl {
                     range: SourceRange {
                         start: SourcePos(
-                            25,
+                            15,
                         ),
                         end: SourcePos(
-                            29,
+                            33,
                         ),
                     },
                     kind: Definition,
@@ -662,10 +662,10 @@ file:///function.ts: EsmModuleSymbol {
                 SymbolDecl {
                     range: SourceRange {
                         start: SourcePos(
-                            24,
+                            15,
                         ),
                         end: SourcePos(
-                            28,
+                            34,
                         ),
                     },
                     kind: Definition,
@@ -735,10 +735,10 @@ file:///class.ts: EsmModuleSymbol {
                 SymbolDecl {
                     range: SourceRange {
                         start: SourcePos(
-                            21,
+                            15,
                         ),
                         end: SourcePos(
-                            25,
+                            29,
                         ),
                     },
                     kind: Definition,

diff --git a/tests/specs/type_tracing/ExportStar01.txt b/tests/specs/type_tracing/ExportStar01.txt
@@ -217,10 +217,10 @@ file:///a.ts: EsmModuleSymbol {
                 SymbolDecl {
                     range: SourceRange {
                         start: SourcePos(
-                            161,
+                            155,
                         ),
                         end: SourcePos(
-                            165,
+                            182,
                         ),
                     },
                     kind: Definition,
@@ -357,10 +357,10 @@ file:///class.ts: EsmModuleSymbol {
                 SymbolDecl {
                     range: SourceRange {
                         start: SourcePos(
-                            21,
+                            15,
                         ),
                         end: SourcePos(
-                            25,
+                            29,
                         ),
                     },
                     kind: Definition,
@@ -430,10 +430,10 @@ file:///function.ts: EsmModuleSymbol {
                 SymbolDecl {
                     range: SourceRange {
                         start: SourcePos(
-                            24,
+                            15,
                         ),
                         end: SourcePos(
-                            28,
+                            34,
                         ),
                     },
                     kind: Definition,
@@ -503,10 +503,10 @@ file:///interface.ts: EsmModuleSymbol {
                 SymbolDecl {
                     range: SourceRange {
                         start: SourcePos(
-                            25,
+                            15,
                         ),
                         end: SourcePos(
-                            29,
+                            33,
                         ),
                     },
                     kind: Definition,

diff --git a/tests/specs/type_tracing/ImportType02.txt b/tests/specs/type_tracing/ImportType02.txt
@@ -147,10 +147,10 @@ file:///a.ts: EsmModuleSymbol {
                 SymbolDecl {
                     range: SourceRange {
                         start: SourcePos(
-                            141,
+                            132,
                         ),
                         end: SourcePos(
-                            145,
+                            151,
                         ),
                     },
                     kind: Definition,