Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rework error handling #878

Open
wants to merge 51 commits into
base: main
Choose a base branch
from

Conversation

crowlKats
Copy link
Member

@crowlKats crowlKats commented Aug 21, 2024

Closes #810

@crowlKats crowlKats marked this pull request as ready for review August 26, 2024 12:29
# Conflicts:
#	core/modules/map.rs
# Conflicts:
#	core/extension_set.rs
#	core/ops.rs
#	core/runtime/jsruntime.rs
# Conflicts:
#	core/error_codes.rs
#	core/ops_builtin.rs
#	core/runtime/op_driver/op_results.rs
#	core/runtime/ops.rs
@crowlKats crowlKats changed the title [WIP] refactor: rework error handling refactor: rework error handling Oct 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2024

Codecov Report

Attention: Patch coverage is 58.99123% with 374 lines in your changes missing coverage. Please review.

Project coverage is 80.91%. Comparing base (0c7f83e) to head (f293421).
Report is 146 commits behind head on main.

Files with missing lines Patch % Lines
core/error.rs 48.36% 126 Missing ⚠️
core/ops_builtin_v8.rs 28.78% 47 Missing ⚠️
core/ops_builtin.rs 28.84% 37 Missing ⚠️
core/modules/loaders.rs 40.38% 31 Missing ⚠️
core/io/resource_table.rs 52.27% 21 Missing ⚠️
core/modules/map.rs 70.76% 19 Missing ⚠️
core/async_cancel.rs 6.66% 14 Missing ⚠️
core/io/resource.rs 0.00% 12 Missing ⚠️
core/runtime/op_driver/op_results.rs 71.42% 10 Missing ⚠️
core/error_codes.rs 0.00% 7 Missing ⚠️
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #878      +/-   ##
==========================================
- Coverage   81.43%   80.91%   -0.53%     
==========================================
  Files          97       97              
  Lines       23877    25210    +1333     
==========================================
+ Hits        19445    20399     +954     
- Misses       4432     4811     +379     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

# Conflicts:
#	Cargo.toml
# Conflicts:
#	Cargo.toml
#	core/Cargo.toml
#	core/extension_set.rs
#	core/lib.rs
#	core/modules/map.rs
#	core/ops.rs
#	core/runtime/bindings.rs
#	core/runtime/jsruntime.rs
#	testing/checkin/runner/ts_module_loader.rs
# Conflicts:
#	Cargo.lock
#	Cargo.toml
#	core/modules/map.rs
# Conflicts:
#	core/runtime/bindings.rs
#	core/runtime/jsruntime.rs
#	core/runtime/snapshot.rs
#	dcore/src/main.rs
#	testing/checkin/runner/ops.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove usages of anyhow::Error in library code
2 participants