feat(core): fast Wasm streaming in Rust #349
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmastrac
reviewed
Dec 2, 2023
| @@ -179,7 +186,6 @@ impl JsRealmInner { | |||
| std::mem::take(&mut realm_state.js_build_custom_error_cb); | |||
| std::mem::take(&mut realm_state.js_promise_reject_cb); | |||
| std::mem::take(&mut realm_state.js_format_exception_cb); | |||
| std::mem::take(&mut realm_state.js_wasm_streaming_cb); | |||
There was a problem hiding this comment.
We should probably still take this one just in case there are globals in the closure. Eventually I'd like to get rid of that explicit intermediate take step but I can't guarantee right now we won't leak bits of the isolate right now.
There was a problem hiding this comment.
I agree with Matt here - can you verify this end-to-end in Deno repo if that doesn't cause problems before merging this PR?
mmastrac
approved these changes
Dec 2, 2023
mmastrac
changed the title
|
Can this PR be landed now? |
|
Looks like this needs a re-merge but it doesn't look too bad. |
|
@littledivy Do you mind if I take a stab at re-merging and landing this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.