Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new "runtime" compiler option #130

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

raashidanwar
Copy link

@raashidanwar raashidanwar commented Oct 22, 2024

Added the new "runtime" Compiler option to support an easier way to configure type checking for other runtimes.

Issue:

src/deno_json/ts.rs Outdated Show resolved Hide resolved
@raashidanwar raashidanwar requested a review from kt3k October 23, 2024 11:21
],
);
} else if contains_deno {
self.insert_libs(options, vec!["deno.ns".to_string()]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be verified with TSC settings in deno, I think we enable more libs for Deno type checking.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure,
Let me know what other libs we need to set or point me so I find myself.

@bartlomieju bartlomieju self-requested a review November 12, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants