fix(ext/crypto): export private x25519 JWK key #27828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
approved these changes
Jan 26, 2025
Comment on lines
+50
to
+51
| let private_key: [u8; 32] = | ||
| private_key.try_into().expect("Expected byteLength 32"); |
There was a problem hiding this comment.
I don't see any logic in JS that would prevent passing keys of other length. Maybe handle it gracefully and return an error?
There was a problem hiding this comment.
This is passed from the inner key handle held by JS which should be already validated. If this panics then there is a bug elsewhere during import/generation of the key.
bartlomieju
pushed a commit
that referenced
this pull request
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #26431