Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ext/node): npm:mqtt compatibility #27792

Merged
merged 9 commits into from
Jan 27, 2025
Merged

fix(ext/node): npm:mqtt compatibility #27792

merged 9 commits into from
Jan 27, 2025

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jan 23, 2025 •
edited
Loading

closes #27694

  • add a test case
  • fix existing tests

@kt3k kt3k added the ci-draft Run the CI on draft PRs. label Jan 23, 2025
@magurotuna
Copy link
Member

I found another similar issue and filed an issue at #27802. Luckily, this patch also fixes it too apparently.

@kt3k kt3k marked this pull request as ready for review January 24, 2025 12:28
littledivy
littledivy approved these changes Jan 25, 2025
View reviewed changes
Copy link
Member

@littledivy littledivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bartlomieju
bartlomieju approved these changes Jan 26, 2025
View reviewed changes
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too

@kt3k kt3k merged commit 2511458 into denoland:main Jan 27, 2025
17 of 20 checks passed
@kt3k kt3k deleted the fix-ext-node-mqtt-compat branch January 27, 2025 02:47
@littledivy littledivy mentioned this pull request Jan 27, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@littledivy littledivy littledivy approved these changes

@bartlomieju bartlomieju bartlomieju approved these changes

Assignees
No one assigned
Labels
ci-draft Run the CI on draft PRs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deno TLS Websocket Connect issue since 2.1.5 (e.g. Mqtt.js)
4 participants
@kt3k @magurotuna @bartlomieju @littledivy