Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ext/fetch): support custom DNS resolver #27740

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(ext/fetch): support custom DNS resolver #27740

wants to merge 2 commits into from

Conversation

zino23
Copy link

@zino23 zino23 commented Jan 20, 2025 •
edited
Loading

  • Declare a new trait Resolve whose only method resolves a Name into Result<SocketAddrs, io::Error> asynchronously.
  • Add a new variant to Resolver encapsulating a custom DNS resolver, and modify Resolver's implementation of Service<Name> accordingly.
  • This new feature is tested in ext/fetch/dns.rs

Fix #27739.

@CLAassistant
Copy link

CLAassistant commented Jan 20, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@zino23 zino23 force-pushed the support-custom-dns-resolver branch from 8efc9e8 to 262c05e Compare January 20, 2025 13:03
@zino23 zino23 force-pushed the support-custom-dns-resolver branch from 262c05e to e14c3b7 Compare January 21, 2025 12:14
@zino23
Copy link
Author

zino23 commented Jan 22, 2025 •
edited
Loading

Hi @bartlomieju, could you take a look on this PR when you are available? I am sorry if I misuse the @ function on you.

@bartlomieju
Copy link
Member

@zino23 what do you need this API for?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ext/fetch: allow to specify a custom DNS resolver
3 participants
@zino23 @CLAassistant @bartlomieju