feat(lint): add support for lint plugin selectors

Cargo.toml

@@ -341,3 +341,6 @@ opt-level = 3
 opt-level = 3
 [profile.release.package.zstd-sys]
 opt-level = 3
+
+[patch.crates-io]
+deno_config = { git = "https://github.com/denoland/deno_config.git", branch = "deno_lint_rules" }

cli/args/flags.rs

@@ -298,6 +298,7 @@ pub struct LintFlags {
   pub json: bool,
   pub compact: bool,
   pub watch: Option<WatchFlags>,
+  pub maybe_plugins: Option<Vec<String>>,
 }
 
 impl LintFlags {
@@ -499,6 +500,7 @@ impl DenoSubcommand {
         | Self::Jupyter(_)
         | Self::Repl(_)
         | Self::Bench(_)
+        | Self::Lint(_)
         | Self::Lsp
     )
   }
@@ -2865,6 +2867,16 @@ To ignore linting on an entire file, you can add an ignore comment at the top of
           .help("Use set of rules with a tag")
           .help_heading(LINT_HEADING),
       )
+      .arg(
+        Arg::new("plugins")
+          .long("plugins")
+          .require_equals(true)
+          .num_args(1..)
+          .action(ArgAction::Append)
+          .use_value_delimiter(true)
+          .help("Plugins to run, relative or absolute paths")
+          .help_heading(LINT_HEADING),
+      )
       .arg(
         Arg::new("rules-include")
           .long("rules-include")
@@ -5133,6 +5145,10 @@ fn lint_parse(
     .remove_many::<String>("rules-exclude")
     .map(|f| f.collect());
 
+  let maybe_plugins = matches
+    .remove_many::<String>("plugins")
+    .map(|f| f.collect());
+
   let json = matches.get_flag("json");
   let compact = matches.get_flag("compact");
 
@@ -5149,6 +5165,7 @@ fn lint_parse(
     json,
     compact,
     watch: watch_arg_parse(matches)?,
+    maybe_plugins,
   });
   Ok(())
 }
@@ -7160,6 +7177,7 @@ mod tests {
           json: false,
           compact: false,
           watch: Default::default(),
+          maybe_plugins: None,
         }),
         ..Flags::default()
       }
@@ -7189,6 +7207,7 @@ mod tests {
           json: false,
           compact: false,
           watch: Some(Default::default()),
+          maybe_plugins: None,
         }),
         permissions: PermissionFlags {
           allow_import: Some(vec![]),
@@ -7226,6 +7245,7 @@ mod tests {
             no_clear_screen: true,
             exclude: vec![],
           }),
+          maybe_plugins: None,
         }),
         ..Flags::default()
       }
@@ -7253,6 +7273,7 @@ mod tests {
           json: false,
           compact: false,
           watch: Default::default(),
+          maybe_plugins: None,
         }),
         ..Flags::default()
       }
@@ -7275,6 +7296,7 @@ mod tests {
           json: false,
           compact: false,
           watch: Default::default(),
+          maybe_plugins: None,
         }),
         ..Flags::default()
       }
@@ -7302,6 +7324,7 @@ mod tests {
           json: false,
           compact: false,
           watch: Default::default(),
+          maybe_plugins: None,
         }),
         ..Flags::default()
       }
@@ -7330,6 +7353,7 @@ mod tests {
           json: false,
           compact: false,
           watch: Default::default(),
+          maybe_plugins: None,
         }),
         ..Flags::default()
       }
@@ -7352,6 +7376,7 @@ mod tests {
           json: true,
           compact: false,
           watch: Default::default(),
+          maybe_plugins: None,
         }),
         ..Flags::default()
       }
@@ -7381,6 +7406,7 @@ mod tests {
           json: true,
           compact: false,
           watch: Default::default(),
+          maybe_plugins: None,
         }),
         config_flag: ConfigFlag::Path("Deno.jsonc".to_string()),
         ..Flags::default()
@@ -7411,11 +7437,42 @@ mod tests {
           json: false,
           compact: true,
           watch: Default::default(),
+          maybe_plugins: None,
         }),
         config_flag: ConfigFlag::Path("Deno.jsonc".to_string()),
         ..Flags::default()
       }
     );
+
+    let r = flags_from_vec(svec![
+      "deno",
+      "lint",
+      "--plugins=./plugins/plugin1.js,/dev/plugins/plugin2.js",
+    ]);
+    assert_eq!(
+      r.unwrap(),
+      Flags {
+        subcommand: DenoSubcommand::Lint(LintFlags {
+          files: FileFlags {
+            include: vec![],
+            ignore: vec![],
+          },
+          fix: false,
+          rules: false,
+          maybe_rules_tags: None,
+          maybe_rules_include: None,
+          maybe_rules_exclude: None,
+          json: false,
+          compact: false,
+          watch: Default::default(),
+          maybe_plugins: Some(vec![
+            "./plugins/plugin1.js".to_string(),
+            "/dev/plugins/plugin2.js".to_string()
+          ]),
+        }),
+        ..Flags::default()
+      }
+    );
   }
 
   #[test]

cli/args/mod.rs

@@ -428,6 +428,7 @@ pub struct LintOptions {
   pub rules: LintRulesConfig,
   pub files: FilePatterns,
   pub fix: bool,
+  pub plugins: Vec<String>,
 }
 
 impl Default for LintOptions {
@@ -442,6 +443,7 @@ impl LintOptions {
       rules: Default::default(),
       files: FilePatterns::new_with_base(base),
       fix: false,
+      plugins: vec![],
     }
   }
 
@@ -455,6 +457,13 @@ impl LintOptions {
         lint_flags.maybe_rules_exclude.clone(),
       ),
       fix: lint_flags.fix,
+      plugins: if !lint_config.options.plugins.is_empty() {
+        lint_config.options.plugins.clone()
+      } else if let Some(plugins) = lint_flags.maybe_plugins.as_ref() {
+        plugins.clone()
+      } else {
+        vec![]
+      },
     }
   }
 }