Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: show remote modules size on deno compile #27415

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: show remote modules size on deno compile #27415

wants to merge 2 commits into from
+33 −0

Conversation

HasanAlrimawi
Copy link
Contributor

closes #27361

Changes

  • Traverses npm_modules of Graph in order to sum the sizes of the modules then print out the size of those remote modules

@bartlomieju bartlomieju requested a review from dsherret December 18, 2024 13:47
dsherret
dsherret reviewed Dec 18, 2024
View reviewed changes
cli/standalone/binary.rs
}
}
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't output this because npm packages are stored in the file system whose size is already displayed.

Let's wait for #27395 to land because implementing this after that will basically just be getting the size from the RemoteModulesStoreBuilder.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsherret dsherret dsherret left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show remote modules in deno compile output
2 participants
@HasanAlrimawi @dsherret