Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ext/node): support private key export in JWK format #27325

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ext/node/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ deno_core::extension!(deno_node,
ops::crypto::keys::op_node_derive_public_key_from_private_key,
ops::crypto::keys::op_node_dh_keys_generate_and_export,
ops::crypto::keys::op_node_export_private_key_der,
ops::crypto::keys::op_node_export_private_key_jwk,
ops::crypto::keys::op_node_export_private_key_pem,
ops::crypto::keys::op_node_export_public_key_der,
ops::crypto::keys::op_node_export_public_key_pem,
Expand Down
66 changes: 66 additions & 0 deletions ext/node/ops/crypto/keys.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ use rsa::pkcs1::DecodeRsaPrivateKey as _;
use rsa::pkcs1::DecodeRsaPublicKey;
use rsa::pkcs1::EncodeRsaPrivateKey as _;
use rsa::pkcs1::EncodeRsaPublicKey;
use rsa::traits::PrivateKeyParts;
use rsa::traits::PublicKeyParts;
use rsa::RsaPrivateKey;
use rsa::RsaPublicKey;
Expand Down Expand Up @@ -2329,6 +2330,71 @@ pub fn op_node_export_private_key_pem(
Ok(String::from_utf8(out).expect("invalid pem is not possible"))
}

#[derive(Debug, thiserror::Error)]
pub enum ExportPrivateKeyJwkError {
#[error(transparent)]
AsymmetricPublicKeyDer(#[from] AsymmetricPrivateKeyDerError),
#[error("very large data")]
VeryLargeData,
#[error(transparent)]
Der(#[from] der::Error),
}

#[op2]
#[serde]
pub fn op_node_export_private_key_jwk(
#[cppgc] handle: &KeyObjectHandle,
) -> Result<deno_core::serde_json::Value, ExportPrivateKeyJwkError> {
let private_key = handle
.as_private_key()
.ok_or(AsymmetricPrivateKeyDerError::KeyIsNotAsymmetricPrivateKey)?;

match private_key {
AsymmetricPrivateKey::Rsa(key) => {
let n = key.n();
let e = key.e();
let d = key.d();
let p = key.primes()[0];
let q = key.primes()[1];
let dp = key.dp();
let dq = key.dq();
let qi = key.crt_coefficient().unwrap();
let oth = &key.primes()[2..];

let mut obj = deno_core::serde_json::json!({
"kty": "RSA",
"n": bytes_to_b64(&n.to_bytes_be()),
"e": bytes_to_b64(&e.to_bytes_be()),
"d": bytes_to_b64(&d.to_bytes_be()),
"p": bytes_to_b64(&p.to_bytes_be()),
"q": bytes_to_b64(&q.to_bytes_be()),
"dp": bytes_to_b64(&p.to_bytes_be()),
"dq": bytes_to_b64(&p.to_bytes_be()),
"qi": bytes_to_b64(&p.to_bytes_be()),
});

if !oth.is_empty() {
obj["oth"] = deno_core::serde_json::json!(oth
.iter()
.map(|o| &o.to_bytes_be())
.collect::<Vec<_>>());
}

return Ok(obj);
}
AsymmetricPrivateKey::RsaPss(key) => Ok(deno_core::serde_json::json!({})),
AsymmetricPrivateKey::Dsa(key) => Ok(deno_core::serde_json::json!({})),
AsymmetricPrivateKey::Ec(key) => Ok(deno_core::serde_json::json!({})),
AsymmetricPrivateKey::X25519(static_secret) => {
Ok(deno_core::serde_json::json!({}))
}
AsymmetricPrivateKey::Ed25519(key) => Ok(deno_core::serde_json::json!({})),
AsymmetricPrivateKey::Dh(key) => Ok(deno_core::serde_json::json!({})),
};

todo!()
}

#[op2]
#[buffer]
pub fn op_node_export_private_key_der(
Expand Down
3 changes: 2 additions & 1 deletion ext/node/polyfills/internal/crypto/keys.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import {
op_node_create_secret_key,
op_node_derive_public_key_from_private_key,
op_node_export_private_key_der,
op_node_export_private_key_jwk,
op_node_export_private_key_pem,
op_node_export_public_key_der,
op_node_export_public_key_jwk,
Expand Down Expand Up @@ -791,7 +792,7 @@ export class PrivateKeyObject extends AsymmetricKeyObject {

export(options: JwkKeyExportOptions | KeyExportOptions<KeyFormat>) {
if (options && options.format === "jwk") {
notImplemented("jwk private key export not implemented");
return op_node_export_private_key_jwk(this[kHandle]);
}
const {
format,
Expand Down
15 changes: 15 additions & 0 deletions jwk.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
import { generateKeyPairSync } from "node:crypto";

const modulusLength = 4096;

const key = generateKeyPairSync("rsa", {
modulusLength,
publicKeyEncoding: {
format: "jwk",
},
privateKeyEncoding: {
format: "jwk",
},
});

console.log(key);
Loading