feat(ext/node): implement node:sqlite
#27308
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartlomieju
requested changes
Dec 15, 2024
cli/bench/sqlite.js
Outdated
There was a problem hiding this comment.
Unrelated to this PR, but... we should have a deno.json file in cli/bench to run various benchmarks. I never remember how to run them and it feels like half of them are already code-rotted.
cli/lsp/tsc.rs
Outdated
| @@ -4496,6 +4496,7 @@ impl<'a> ToV8<'a> for TscRequestArray { | |||
|
|
|||
| let method_name = deno_core::FastString::from_static(method_name) | |||
| .v8_string(scope) | |||
| .unwrap() | |||
There was a problem hiding this comment.
Ugh, I must have missed that. Why is it now a Result/Option?
There was a problem hiding this comment.
littledivy
added a commit
that referenced
this pull request
Dec 16, 2024
upgrades itoa requirement to `1.0.14`. needed for #27308
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
#[varargs]in object wrap deno_core#994extension!macro deno_core#993TypeIdnot reliable for object wrap templates deno_core#999Closes #24828