feat: make permission prompter thread-local #27161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bartlomieju
reviewed
Dec 5, 2024
Comment on lines
+91
to
+92
| MAYBE_BEFORE_PROMPT_CALLBACK.with(|cb| *cb.lock() = Some(before_callback)); | ||
| MAYBE_AFTER_PROMPT_CALLBACK.with(|cb| *cb.lock() = Some(after_callback)); |
There was a problem hiding this comment.
This is now incorrect - if these are thread locals then set_prompt_callback needs to be called in each worker thread spawned - you'd need to update op_create_worker in runtime/ops/worker_host.rs
There was a problem hiding this comment.
I see! That makes sense. Thanks @bartlomieju!
I'll work on updating worker_host.rs. I have some ideas and will test them to see what works best.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using
deno_runtimein multiple threads and trying to use different prompters to manage the permissions independently, I hit a roadblock becausePERMISSION_PROMPTERis static. This is an example of how I'm usingdeno_runtime: https://github.com/carloslfu/tauri-deno-example.This solution uses the
thread_local!macro to make the necessary variables thread-local and adapts the corresponding functions.This PR addresses #27160.