fix: Ensure lockfile has deterministic serialization of unordered hashes #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Owner
|
We could update all the callsites, I dont think there are that many |
hinshun
force-pushed
the
feature/reproducible-lockfile
branch
from
0f087f2 to
8073e94
Compare
Contributor
Author
|
I updated all the callsites, I think it's cleaner too but some folks prefer smaller diffs. |
Owner
|
I like big changes, how else can we innovate lol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since HashMap is unordered, the lockfile produced is non-deterministic because the hashes are serialized in a random order. This is a problem for environments like Nix where we want determinism.
Alternatively, we change
pub hashestoBTreeMapbut we'll have update all the callsites, this is the minimal fix. Let me know what you prefer.