Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #12 🎫: General Shopping List (Shopping List) #24

Merged
merged 9 commits into from
Dec 21, 2023

Conversation

ITurres
Copy link
Collaborator

@ITurres ITurres commented Dec 21, 2023

Pull Request Summary for Issue #12 Completion


Added:

/app/controllers/shopping_lists_controller.rb

  • The controller will be used to create a shopping list for a recipe. The show action will be used to display the shopping list for a recipe.

/app/views/shopping_lists/show.html.erb

  • I have added the view for the shopping list as per the wireframe.

/spec/controllers/shopping_lists_controller_spec.rb

  • I have added the controller spec for the shopping list controller.

/spec/views/shopping_lists/show.html.erb_spec.rb

  • I have added the view spec for the shopping list view.

Modified:

/app/views/layouts/_navbar.html.erb

  • I removed the waning comment, since now we got all the links correctly pointing to the right place.
  • The shopping list link path was modified to point to the show action of the shopping list controller.

/app/views/recipes/show.html.erb

  • I swap the button for a link to the shopping list show action, so the user is link to the shopping list for the recipe.

/config/routes.rb

  • I added the shopping list resource to the routes file.

Thank you for reviewing this PR. Feel free to reach out on Slack as Arturo (Arthur) Emanuel Guerra Iturres for any queries or further assistance. 🌟

@ITurres ITurres added enhancement New feature or request Tests Unit Test and Integration Test UI Views and Interfaces labels Dec 21, 2023
@ITurres ITurres linked an issue Dec 21, 2023 that may be closed by this pull request
@ITurres ITurres assigned ITurres and unassigned demesameneshoa Dec 21, 2023
Copy link
Owner

@demesameneshoa demesameneshoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ITurres ,

Highlights!

  • Shopping list view implemented ✔️
  • Good code organization and working app ✔️
  • Passing unit and integration tests✔️

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Status: Approved ✔️

Cheers and Happy coding!👏👏👏

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Feel free to leave any questions or comments in the PR thread by tagging me with @demesameneshoa if something is not 100% clear.


@demesameneshoa demesameneshoa merged commit 50942d4 into dev Dec 21, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Tests Unit Test and Integration Test UI Views and Interfaces
Projects
Development

Successfully merging this pull request may close these issues.

[4pt] - General Shopping List
2 participants