Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #6 🎫: Public recipes #22

Merged
merged 5 commits into from
Dec 20, 2023
Merged

Issue #6 🎫: Public recipes #22

merged 5 commits into from
Dec 20, 2023

Conversation

ITurres
Copy link
Collaborator

@ITurres ITurres commented Dec 20, 2023

Pull Request Summary for Issue #6 Completion


Added:

/app/models/recipe_food.rb

  • This is the join table (model) for the many-to-many relationship between recipes and foods.

/app/views/recipes/public_index.html.erb

  • The view for the public index action.

/spec/views/recipes/public_index.html.erb_spec.rb

  • The spec for the public index view.

Modified:

/app/controllers/recipes_controller.rb

  • I have added the public_index action to render the public index view with all the recipes that are not private and in descending order by creation date.

/app/views/layouts/_navbar.html.erb

  • I changed the My-recipes link_to path to recipes_path.

/config/routes.rb

  • I changed the root path to recipes#public_index.

Thank you for reviewing this PR. Feel free to reach out on Slack as Arturo (Arthur) Emanuel Guerra Iturres for any queries or further assistance. 🌟

@ITurres ITurres added enhancement New feature or request Tests Unit Test and Integration Test UI Views and Interfaces labels Dec 20, 2023
@ITurres ITurres self-assigned this Dec 20, 2023
@ITurres ITurres linked an issue Dec 20, 2023 that may be closed by this pull request
Copy link
Owner

@demesameneshoa demesameneshoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ITurres ,

Highlights!

  • Public recipe view implemented ✔️
  • Good code organization and working app ✔️
  • Passing unit and integration tests✔️

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Status: Approved ✔️

Cheers and Happy coding!👏👏👏

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Feel free to leave any questions or comments in the PR thread by tagging me with @demesameneshoa if something is not 100% clear.


@demesameneshoa demesameneshoa merged commit 3c5301a into dev Dec 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Tests Unit Test and Integration Test UI Views and Interfaces
Projects
Development

Successfully merging this pull request may close these issues.

[4pt] - Public recipe list
2 participants