fix: still work if user has no camera or mic#89
Open
WofWca wants to merge 2 commits intowofwca/connectionstate-for-in-call-statefrom
Open
fix: still work if user has no camera or mic#89WofWca wants to merge 2 commits intowofwca/connectionstate-for-in-call-statefrom
WofWca wants to merge 2 commits intowofwca/connectionstate-for-in-call-statefrom
Conversation
This ensured that we tell the user that the call has started even if the other party fails to (or maliciously decides not to) send their media stream.
It makes sense, because maybe the users are fine with one of them not having video or audio.
WofWca
force-pushed
the
wofwca/connectionstate-for-in-call-state
branch
from
d6551f7 to
f1866e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It makes sense, because maybe the users are fine
with one of them not having video or audio.
I have tested this.
TODO: