[KERNEL] Fix toString in StringType
#5866
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilicmarkodb
force-pushed
the
fix_to_string
branch
from
0b3508f to
def7b83
Compare
stefankandic
approved these changes
Jan 16, 2026
ilicmarkodb
force-pushed
the
fix_to_string
branch
from
def7b83 to
7f3a0b6
Compare
ilicmarkodb
force-pushed
the
fix_to_string
branch
from
7f3a0b6 to
36b8481
Compare
ilicmarkodb
commented
Jan 19, 2026
Comment on lines
-66
to
+72
| // DecimalType is eligible but since its string includes scale + precision it needs to | ||
| // be matched separately | ||
| dataType instanceof DecimalType; | ||
| // DecimalType is eligible, but since its string includes scale + precision, it needs to | ||
| // be matched separately. | ||
| dataType instanceof DecimalType | ||
| || | ||
| // StringType is eligible, but since its string can include collation info, it needs to | ||
| // be matched separately. | ||
| dataType instanceof StringType; |
Contributor
Author
There was a problem hiding this comment.
Maybe we should follow up on this and make this a method on DataType?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Delta project/connector is this regarding?
Description
Fix
toStringinStringTypeto include collation information.How was this patch tested?
New unit tests.
Does this PR introduce any user-facing changes?
No.