[Kernel-Spark] Phase 1: Basic Deletion Vector read support #5774
+450
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huan233usc
force-pushed
the
stack/dv_pr2_phase1_basic_read
branch
4 times, most recently
from
4edc486 to
a75472d
Compare
huan233usc
force-pushed
the
stack/dv_pr2_phase1_basic_read
branch
23 times, most recently
from
9614135 to
07406cd
Compare
…-io#5813) <!-- Thanks for sending a pull request! Here are some tips for you: 1. If this is your first time, please read our contributor guidelines: https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md 2. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP] Your PR title ...'. 3. Be sure to keep the PR description updated to reflect all changes. 4. Please write your PR title to summarize what this PR proposes. 5. If possible, provide a concise example to reproduce the issue for a faster review. 6. If applicable, include the corresponding issue number in the PR title and link it in the body. --> #### Which Delta project/connector is this regarding? <!-- Please add the component selected below to the beginning of the pull request title For example: [Spark] Title of my pull request --> - [ ] Spark - [ ] Standalone - [x] Flink - [ ] Kernel - [ ] Other (fill in here) ## Description This PR introduce the basic build support into `build.sbt` for Flink connector. It also introduce multiple interface classes that Flink connector can use to access Delta Kernel. <!-- - Describe what this PR changes. - Describe why we need the change. If this PR resolves an issue be sure to include "Resolves #XXX" to correctly link and close the issue upon merge. --> ## How was this patch tested? UT <!-- If tests were added, say they were added here. Please make sure to test the changes thoroughly including negative and positive cases if possible. If the changes were tested in any way other than unit tests, please clarify how you tested step by step (ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future). If the changes were not tested, please explain why. --> ## Does this PR introduce _any_ user-facing changes? No <!-- If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible. If possible, please also clarify if this is a user-facing change compared to the released Delta Lake versions or within the unreleased branches such as master. If no, write 'No'. -->
delta-io#5813)" (delta-io#5868) This reverts commit 52bc9d2. #### Which Delta project/connector is this regarding? - [ ] Spark - [ ] Standalone - [X] Flink - [ ] Kernel - [ ] Other (fill in here) ## Description Reverting 52bc9d2. Want it merged with all the right approvals. ## How was this patch tested? Just a revert. ## Does this PR introduce _any_ user-facing changes? No.
This PR implements Phase 1 of DV support in the V2 connector with the following features: 1. DV metadata in PartitionedFile: - Convert Kernel DeletionVectorDescriptor to Spark format - Store serialized DV in otherConstantMetadataColumnValues 2. Schema augmentation: - Add __delta_internal_is_row_deleted column when table has DVs - DeltaParquetFileFormat generates this column using DV bitmap 3. DV filtering in connector: - DVFilteringIterator filters rows where is_row_deleted != 0 - Projects out the DV column from output (clean data to Spark) 4. Phase 1 limitations (to be addressed in later phases): - Vectorized reader disabled (Phase 2 will add ColumnarBatch support) - File splitting disabled (Phase 3 will use _metadata.row_index) The connector returns clean, already-filtered data - Spark plans never see DV columns.
huan233usc
force-pushed
the
stack/dv_pr2_phase1_basic_read
branch
7 times, most recently
from
d1528af to
e299735
Compare
huan233usc
force-pushed
the
stack/dv_pr2_phase1_basic_read
branch
from
e299735 to
78715ca
Compare
huan233usc
requested review from
gengliangwang,
tdas and
zikangh
and removed request for
gengliangwang and
zikangh
Collaborator
Author
|
@juliuszsompolski Can you also review this PR (and the stack)? All are DV related. |
Contributor
|
Thanks, I will take a look! @andreaschat-db could you also review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
Which Delta project/connector is this regarding?
Description
Add basic deletion vector (DV) read support for the Spark V2 connector using row-based filtering.
Changes:
DvSchemaContext: POJO to manage DV schema context (column indices, output schema)DeletionVectorReadFunction: Wraps base reader to filter deleted rows and project out DV columnPartitionUtils: Creates DV-awarePartitionReaderFactorywithDeltaParquetFileFormatV2serializeToBase64()to Kernel'sDeletionVectorDescriptorHow it works:
__delta_internal_is_row_deletedcolumn to read schemaHow was this patch tested?
DvSchemaContextTest: Unit tests for schema manipulationDeletionVectorReadFunctionTest: Unit tests for row filtering and projectionDoes this PR introduce any user-facing changes?
No