feat: retryable config enablement through storage_options #3129
+168
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ion-elgreco
requested review from
wjones127,
roeap,
rtyler and
hntd187
as code owners
ion-elgreco
force-pushed
the
feat/configurable_retry
branch
from
eb8fb9b to
96179b0
Compare
Signed-off-by: Ion Koutsouris <[email protected]>
ion-elgreco
force-pushed
the
feat/configurable_retry
branch
from
96179b0 to
4085c3d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3129 +/- ##
==========================================
- Coverage 72.28% 72.23% -0.05%
==========================================
Files 134 134
Lines 42973 43059 +86
Branches 42973 43059 +86
==========================================
+ Hits 31062 31104 +42
- Misses 9923 9956 +33
- Partials 1988 1999 +11 ☔ View full report in Codecov by Sentry. |
roeap
reviewed
Jan 14, 2025
| let inner = builder | ||
| .with_retry(self.parse_retry_config(&options)?) | ||
| .build()?; | ||
|
|
||
| let store = limit_store_handler(url_prefix_handler(inner, prefix.clone()), options); |
There was a problem hiding this comment.
Not related to this PR, but why do we wrap this in the limiting store again?
There was a problem hiding this comment.
Its due to this PR: #2458
I will put a small PR to actually document this storage option
There was a problem hiding this comment.
@roeap I've added docs in this PR, and also included the the other undocumented options :)
Signed-off-by: Ion Koutsouris <[email protected]>
ion-elgreco
force-pushed
the
feat/configurable_retry
branch
from
8564ac9 to
4c46287
Compare
Signed-off-by: Ion Koutsouris <[email protected]>
ion-elgreco
force-pushed
the
feat/configurable_retry
branch
from
b94227d to
a2639e9
Compare
rtyler
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description