Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use kernel table features #3117

Merged

Conversation

ion-elgreco
Copy link
Collaborator

Description

Swapped out table features code from internal to delta-kernel-rs.

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Jan 12, 2025
@ion-elgreco ion-elgreco force-pushed the refactor--kernel-table-features branch from 7d42d50 to 5dd7f7f Compare January 12, 2025 09:59
Signed-off-by: Ion Koutsouris <[email protected]>
@ion-elgreco ion-elgreco force-pushed the refactor--kernel-table-features branch from 5dd7f7f to b5d6dbe Compare January 12, 2025 10:13
@ion-elgreco ion-elgreco enabled auto-merge January 12, 2025 10:24
Copy link

codecov bot commented Jan 12, 2025

Codecov Report

Attention: Patch coverage is 53.33333% with 35 lines in your changes missing coverage. Please review.

Project coverage is 72.22%. Comparing base (b831543) to head (b5d6dbe).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/protocol/parquet_read/mod.rs 0.00% 16 Missing and 4 partials ⚠️
crates/core/src/kernel/models/actions.rs 51.72% 13 Missing and 1 partial ⚠️
crates/core/src/operations/write.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3117      +/-   ##
==========================================
+ Coverage   72.18%   72.22%   +0.03%     
==========================================
  Files         134      134              
  Lines       42962    42903      -59     
  Branches    42962    42903      -59     
==========================================
- Hits        31014    30985      -29     
+ Misses       9962     9925      -37     
- Partials     1986     1993       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@roeap roeap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ion-elgreco ion-elgreco added this pull request to the merge queue Jan 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 12, 2025
@ion-elgreco ion-elgreco added this pull request to the merge queue Jan 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 12, 2025
@ion-elgreco ion-elgreco added this pull request to the merge queue Jan 12, 2025
Merged via the queue into delta-io:main with commit 1bb60ee Jan 12, 2025
23 checks passed
@ion-elgreco ion-elgreco deleted the refactor--kernel-table-features branch January 12, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants