Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use of deprecated DeltaTable::peek_next_commit #3080

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jkylling
Copy link
Contributor

Maybe we could run CI with

cargo clippy ... -- -D warnings

to catch this early?

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Dec 22, 2024
@jkylling jkylling force-pushed the remove-use-of-deprecated-peek_next_commit branch from 74922ad to 97e7fcf Compare December 22, 2024 17:57
@roeap
Copy link
Collaborator

roeap commented Dec 22, 2024

Good idea! Feel free to update this :).

Right now I am looking into how we can more deeply integrate with delta-kernel-rs, and APIs like these make this somewhat hard.

So interested in your use case for using this API at all :).

For context, over simplified, there are two kinds of users - the ones who only want the right data and do not care about the log at all, and the ones who care almost exclusively about the log...

In this case, would the CDF APIs also work for you?

Copy link

codecov bot commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.41%. Comparing base (cdc6473) to head (97e7fcf).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3080   +/-   ##
=======================================
  Coverage   72.41%   72.41%           
=======================================
  Files         128      128           
  Lines       41017    41025    +8     
  Branches    41017    41025    +8     
=======================================
+ Hits        29701    29707    +6     
- Misses       9423     9435   +12     
+ Partials     1893     1883   -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants