Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: api changes for Datafusion 44 #3073

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

chore: api changes for Datafusion 44 #3073

wants to merge 7 commits into from

Conversation

rtyler
Copy link
Member

@rtyler rtyler commented Dec 21, 2024

This is currently a work in progress to help pre-test Datafusion 44 before it's released

@github-actions github-actions bot added the binding/rust Issues for the Rust crate label Dec 21, 2024
Copy link

ACTION NEEDED

delta-rs follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@alamb
Copy link

alamb commented Dec 21, 2024

I made a PR here to pin to a pre-release version of DataFusion for testing:

There are a bunch of deprecation warnings which I will work on but I am out of time today. Hopefully tomorrow

Thanks again @rtyler

@rtyler rtyler changed the title chore: API changes fro Datafusion 44 chore: api changes fro Datafusion 44 Dec 21, 2024
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 72.29%. Comparing base (72311ed) to head (62ecf57).

Files with missing lines Patch % Lines
crates/core/src/delta_datafusion/expr.rs 50.00% 0 Missing and 1 partial ⚠️
crates/core/src/operations/optimize.rs 66.66% 0 Missing and 1 partial ⚠️
crates/sql/src/parser.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3073   +/-   ##
=======================================
  Coverage   72.29%   72.29%           
=======================================
  Files         128      128           
  Lines       41165    41164    -1     
  Branches    41165    41164    -1     
=======================================
  Hits        29761    29761           
+ Misses       9492     9488    -4     
- Partials     1912     1915    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rtyler rtyler changed the title chore: api changes fro Datafusion 44 chore: api changes for Datafusion 44 Dec 22, 2024
…aFusion APIs (#3077)

- targets #3073 from @rtyler 

This PR makes some small changes to reduce the build warnings by using
non deprecated APIs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
binding/rust Issues for the Rust crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants