Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose cleanup_metadata in Python #1826

Merged
merged 2 commits into from
Nov 15, 2023
Merged

feat: expose cleanup_metadata in Python #1826

merged 2 commits into from
Nov 15, 2023

Conversation

r3stl355
Copy link
Contributor

@r3stl355 r3stl355 commented Nov 8, 2023

Description

  • exposed existing cleanup_metadata from Rust in Python bindings
  • added a Python unit test

Related Issue(s)

@github-actions github-actions bot added the binding/python Issues for the Python package label Nov 8, 2023
wjones127
wjones127 previously approved these changes Nov 10, 2023
View reviewed changes
Copy link
Collaborator

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor ask, otherwise looks good!

python/deltalake/table.py Outdated Show resolved Hide resolved
@r3stl355
Copy link
Contributor Author

Hey @wjones127, the benchmark build is failing but I can't see how that can be related to my PR, any thoughts?

@rtyler rtyler enabled auto-merge (rebase) November 15, 2023 17:19
@rtyler rtyler requested a review from ion-elgreco as a code owner November 15, 2023 17:19
@r3stl355 @ion-elgreco
implement issue 1768
a922c27 
Signed-off-by: Nikolay Ulmasov <[email protected]>
@r3stl355 @ion-elgreco
add default retention value to docs
408a8f0 
Signed-off-by: Nikolay Ulmasov <[email protected]>
@rtyler rtyler merged commit 5c324cc into delta-io:main Nov 15, 2023
24 checks passed
@r3stl355
Copy link
Contributor Author

Thank you for merging this!!

@yefetBenTili yefetBenTili mentioned this pull request Dec 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjones127 wjones127 wjones127 approved these changes

@fvaleye fvaleye Awaiting requested review from fvaleye fvaleye is a code owner

@roeap roeap Awaiting requested review from roeap roeap is a code owner

@ion-elgreco ion-elgreco Awaiting requested review from ion-elgreco ion-elgreco is a code owner

Assignees
No one assigned
Labels
binding/python Issues for the Python package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose cleanup_metadata or create_checkpoint_from_table_uri_and_cleanup to the Python API
3 participants
@r3stl355 @wjones127 @rtyler